move sortable and no_index to the field field abstract… #118
Conversation
redisearch/client.py
Outdated
| if no_index and not sortable: | ||
| raise ValueError('Non-Sortable non-Indexable fields are ignored') | ||
| Field.__init__(self, name, *args) | ||
| Field.__init__(self, name, *args, **kwargs) |
There was a problem hiding this comment.
Usually you put the call to the father as the first call in the constructor. Maybe we can call it first and create an add_arg function of the father that the child can use to add the extra arguments after? WDYT?
There was a problem hiding this comment.
why not just use self.args.append directly (instead of adding the add_arg function)?
There was a problem hiding this comment.
Also, the sortable and no_index flags (which being added in Field.__init__) should be at the end
There was a problem hiding this comment.
Exactly because of that, if you expose it as a method then it's an API and the father can decide to implement it anyway it wants. He can save it on a separate array and manage the arguments positions (for example)..
|
Kudos, SonarCloud Quality Gate passed!
|
will fix #34 and #116