Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more examples #121

Merged
merged 1 commit into from
May 4, 2021
Merged

Add more examples #121

merged 1 commit into from
May 4, 2021

Conversation

abrookins
Copy link
Contributor

@abrookins abrookins commented Apr 24, 2021 •
edited
Loading

Add more examples of working with indexes, querying, and the aggregations API.

@codecov
Copy link

codecov bot commented Apr 24, 2021 •
edited
Loading

Codecov Report

Merging #121 (a6923c9) into master (a95665d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a6923c9 differs from pull request most recent head a757b9c. Consider uploading reports for the commit a757b9c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   90.17%   90.18%           
=======================================
  Files          12       12           
  Lines        1700     1701    +1     
=======================================
+ Hits         1533     1534    +1     
  Misses        167      167
Impacted Files Coverage Δ
redisearch/__init__.py 100.00% <100.00%> (ø)
redisearch/client.py 85.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95665d...a757b9c. Read the comment docs.

@abrookins abrookins marked this pull request as ready for review April 26, 2021 19:33
@abrookins
Copy link
Contributor Author

@gkorland @emmanuelkeller Can you review? Thanks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gkorland gkorland requested a review from emmanuelkeller April 28, 2021 15:56
emmanuelkeller
emmanuelkeller approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@emmanuelkeller emmanuelkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkorland gkorland merged commit 6fa0721 into RediSearch:master May 4, 2021
@gkorland gkorland added the docs label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelkeller emmanuelkeller emmanuelkeller approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abrookins @emmanuelkeller @gkorland