Skip to content

feat: Add double metaphone phonetic matcher #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2020
Merged

feat: Add double metaphone phonetic matcher #55

merged 2 commits into from
Feb 17, 2020

Conversation

joeirimpan
Copy link
Contributor

@gkorland gkorland requested a review from mnunberg February 12, 2020 08:19
@MeirShpilraien
Copy link

Can we add test for it?

@joeirimpan
Copy link
Contributor Author

@MeirShpilraien I ve added the test now

MeirShpilraien
MeirShpilraien previously approved these changes Feb 17, 2020
View reviewed changes
Copy link

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joeirimpan looks good.

@gkorland gkorland removed the request for review from mnunberg February 17, 2020 13:08
@gkorland gkorland merged commit c682ce5 into RediSearch:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@MeirShpilraien MeirShpilraien MeirShpilraien left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeirimpan @MeirShpilraien @gkorland