Support FT.CONFIG command #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkorland
suggested changes
Apr 5, 2020
itamarhaber
reviewed
Apr 5, 2020
|
Looks good but for consistency, I'd rename the methods. |
|
@itamarhaber Thanks for reviewing. It was done. |
ashtul
reviewed
Jul 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 90.42% 90.55% +0.13%
==========================================
Files 12 12
Lines 1472 1493 +21
==========================================
+ Hits 1331 1352 +21
Misses 141 141
Continue to review full report at Codecov.
|
ashtul
approved these changes
Jul 9, 2020
gkorland
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.