Proposed fix for #67 #68
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quintonparker |
|
@quintonparker can you add a test for this? |
|
lgtm otherwise |
quintonparker
force-pushed
the
value-error-issue-67
branch
from
b6f1e71 to
455ecdf
Compare
|
@mnunberg oops. my bad. rebased with a test |
ashtul
reviewed
May 14, 2020
| @@ -86,8 +86,6 @@ class Group(object): | |||
| This object automatically created in the `AggregateRequest.group_by()` | |||
| """ | |||
| def __init__(self, fields, reducers): | |||
| if not fields: | |||
There was a problem hiding this comment.
@quintonparker
Why remove this and then remove the test?
Aren't they both relevant?
There was a problem hiding this comment.
basically, aggregation queries that is possible on the cli is not reproducible with redisearch-py because this code is enforcing the fields var to be non-empty
ashtul
approved these changes
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.