Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connection #82

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Conversation

surajptl
Copy link
Contributor

cloud connection should be required password to connect

cloud connection should be required password to connect
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files          12       12           
  Lines        1587     1587           
=======================================
  Hits         1451     1451           
  Misses        136      136           
Impacted Files Coverage Δ
redisearch/auto_complete.py 93.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ec721...42e732d. Read the comment docs.

@gkorland
Copy link
Contributor

@surajptl this is why the constructor has conn = None so you can customize the connection as you want. E.g. with Redis 6 new ACL you can use user & password.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ashtul ashtul merged commit 0a0c283 into RediSearch:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants