Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dag V2 tests #51

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Fix Dag V2 tests #51

merged 3 commits into from
Jul 14, 2021

Conversation

sazzad16
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #51 (546c331) into master (b6b9871) will increase coverage by 4.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   81.75%   86.73%   +4.98%     
==========================================
  Files          12       12              
  Lines         800      799       -1     
  Branches      113      112       -1     
==========================================
+ Hits          654      693      +39     
+ Misses         97       53      -44     
- Partials       49       53       +4     
Impacted Files Coverage Δ
src/main/java/com/redislabs/redisai/Dag.java 86.48% <100.00%> (+33.85%) ⬆️
src/main/java/com/redislabs/redisai/Keyword.java 100.00% <100.00%> (ø)
src/main/java/com/redislabs/redisai/RedisAI.java 81.22% <100.00%> (+5.24%) ⬆️
src/main/java/com/redislabs/redisai/Model.java 90.76% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b9871...546c331. Read the comment docs.

Copy link
Contributor Author

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DvirDukhan please merge this PR

@sazzad16 sazzad16 changed the title Dag V2 tests do not work Fix Dag V2 tests Jul 13, 2021
DvirDukhan
DvirDukhan previously approved these changes Jul 14, 2021
@sazzad16 sazzad16 merged commit 303f10c into master Jul 14, 2021
@sazzad16 sazzad16 deleted the dag-v2-tests branch July 14, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants