onnxruntime 1.7.2 build and documentation #785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
==========================================
- Coverage 79.99% 79.96% -0.04%
==========================================
Files 53 53
Lines 8032 8019 -13
==========================================
- Hits 6425 6412 -13
Misses 1607 1607
Continue to review full report at Codecov.
|
chayim
changed the title
This was referenced Jul 27, 2021
DvirDukhan
reviewed
Aug 2, 2021
| @@ -1,134 +1,16 @@ | |||
| REDIS_ONNX_VERSION?=rel-1.7.2_RCE | |||
There was a problem hiding this comment.
this is the branch name?
| #---------------------------------------------------------------------------------------------- | ||
| {% if REDIS_ARCH == 'x64' %} | ||
| {% if REDIS_GPU is defined %} | ||
| FROM nvidia/cuda:11.0-cudnn8-devel-ubuntu18.04 |
There was a problem hiding this comment.
maybe allow user to define their cuda version?
we use 11.0
might want to compile it on newer versions
Merged
|
moved to #847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected how we build onnx. We can now build and release on x64, and x64 gpu. This will build on osx x64 as well, and version 1.8 of onnx now builds (using these changes) on jetson. This PR is only for 1.7.2. A new developer should be able to use the accompanying instructions, in order to work on the onnx build should they so desire.
This would be the template for building back-ends. ci was built in full and the remaining run is for changing circleci back to master's norm.