Fix the openssl path for the macOS builds. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "/usr/local/opt/openssl@1.1", | ||
| "/opt/homebrew/opt/openssl@1.1", | ||
| ]; | ||
| probe_paths(&PATHS).unwrap_or("") |
There was a problem hiding this comment.
Do we want to fail the build in case we did not find a match?
There was a problem hiding this comment.
Not necessarily, in case there are other, probably default paths, where the library might be located. We just checked that we couldn't find it on our own, but that doesn't mean it isn't there.
MeirShpilraien
approved these changes
Mar 3, 2023
Changes the way the build script figures out the openssl library path. Now it takes into account the commonly-used OPENSSL_PREFIX environment variable and attempts to probe certain pre-defined directories to figure out the path.
iddm
force-pushed
the
fix-openssl-on-macos
branch
from
a876ee8 to
546715b
Compare
MeirShpilraien
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the way the build script figures out the openssl library path. Now it takes into account the commonly-used OPENSSL_PREFIX environment variable and attempts to probe certain pre-defined directories to figure out the path.