Fix use after free of native function return value. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we call a native function we should avoid creating a new isolate scope because when the isolate scope will be freed, all the local handlers will be marked for GC and potenatially freed as well. This includes the return value. To avoid that, we create a dummy isolate scope. From user POV, the dummy isolate scope can be used like a regular isolate scope, But it will not cause local handler to be freed when it is released.
|
We should check if it is possible to rewrite this "dummy" isolate to a strong type with lifetimes and make sure we don't rely on some knowledge, such as "we know that ...". |
iddm
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we call a native function we should avoid creating a new isolate scope because when the isolate scope will be freed, all the local handlers will be marked for GC and potenatially freed as well. This includes the return value.
To avoid that, we create a dummy isolate scope. From user POV, the dummy isolate scope can be used like a regular isolate scope, But it will not cause local handler to be freed when it is released.