Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON.GET: interface conversion: interface {} is string #246

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Fix JSON.GET: interface conversion: interface {} is string #246

merged 2 commits into from
Dec 6, 2021

Conversation

mikhail-vl
Copy link
Contributor

@mikhail-vl mikhail-vl commented Dec 5, 2021 •
edited
Loading

Fixes #238.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Dec 5, 2021
@mikhail-vl mikhail-vl added this to the Version 2.1.0 milestone Dec 5, 2021
@mikhail-vl mikhail-vl self-assigned this Dec 5, 2021
@codecov
Copy link

codecov bot commented Dec 5, 2021 •
edited
Loading

Codecov Report

Merging #246 (4ade174) into master (e374cab) will decrease coverage by 0.15%.
The diff coverage is 82.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   94.75%   94.59%   -0.16%     
==========================================
  Files          39       39              
  Lines        1791     1812      +21     
  Branches       79       79              
==========================================
+ Hits         1697     1714      +17     
- Misses         85       89       +4     
  Partials        9        9
Impacted Files Coverage Δ
pkg/redis-json.go 90.29% <82.97%> (-2.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e374cab...4ade174. Read the comment docs.

@mikhail-vl mikhail-vl merged commit 1d34651 into master Dec 6, 2021
@mikhail-vl mikhail-vl deleted the feat/fix-json-get branch December 6, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikhail-vl mikhail-vl

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 2.1.0
Development

Successfully merging this pull request may close these issues.

JSON.GET: interface conversion: interface {} is string, not map[string]interface {}
1 participant
@mikhail-vl