Add Field config units to the response #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again @ryantxu for the advice! |
|
@mikhailredis we probably want to apply that to RedisTimeSeries response as well. |
mikhail-vl
changed the title
@danni-m RedisTimeSeries responses in time.Time already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One feature I am super excited about is having datasources tell the UI what the units are so that panel authors do not need to know.
This shows an example how you can set the duration field to automatically show up as "ms" -- valid strings are anything you put in the editor. the defautls are: https://github.com/grafana/grafana/blob/master/packages/grafana-data/src/valueFormats/categories.ts#L326, but if you put in an unknown string it will become a suffix for the display