Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backend lint issues #41

Merged
merged 5 commits into from
Aug 14, 2020
Merged

Fix backend lint issues #41

merged 5 commits into from
Aug 14, 2020

Conversation

mikhail-vl
Copy link
Contributor

exec: golangci-lint run ./...
pkg/grafana-redis-datasource.go:69:6: ineffectual assignment to `status` (ineffassign)
	var status = backend.HealthStatusUnknown
	    ^
pkg/commands.go:137:9: S1034: assigning the result of this type assertion to a variable (switch result := result.(type)) could eliminate the following type assertions:
	pkg/commands.go:140:12
	pkg/commands.go:147:19
	pkg/commands.go:163:12 (gosimple)
	switch result.(type) {
	       ^
pkg/commands.go:172:11: S1034: assigning the result of this type assertion to a variable (switch value := value.(type)) could eliminate the following type assertions:
	pkg/commands.go:174:36 (gosimple)
			switch value.(type) {
			       ^
pkg/commands.go:180:13: S1034: assigning the result of this type assertion to a variable (switch element := element.(type)) could eliminate the following type assertions:
	pkg/commands.go:182:38
	pkg/commands.go:184:31 (gosimple)
					switch element.(type) {
					       ^
pkg/commands.go:311:9: S1034: assigning the result of this type assertion to a variable (switch result := result.(type)) could eliminate the following type assertions:
	pkg/commands.go:313:31 (gosimple)
	switch result.(type) {
	       ^
pkg/commands.go:777:11: S1034: assigning the result of this type assertion to a variable (switch arg := arg.(type)) could eliminate the following type assertions:
	pkg/commands.go:779:34
	pkg/commands.go:781:23
	pkg/commands.go:783:16 (gosimple)
			switch arg.(type) {
			       ^
Error: running "golangci-lint run ./..." failed with exit code 1

Exited with code exit status 1
CircleCI received exit code 1

@mikhail-vl mikhail-vl added the bug Something isn't working label Aug 13, 2020
@mikhail-vl mikhail-vl added this to the Version 1.2 milestone Aug 13, 2020
@mikhail-vl mikhail-vl self-assigned this Aug 13, 2020
Copy link
Contributor Author

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 41fb6b1 into master Aug 14, 2020
@mikhail-vl mikhail-vl deleted the fix/ci-build-issues branch August 14, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant