Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRANGE: add fill zero option #53

Merged
merged 1 commit into from
Aug 23, 2020
Merged

MRANGE: add fill zero option #53

merged 1 commit into from
Aug 23, 2020

Conversation

dpipemazo
Copy link
Contributor

@dpipemazo dpipemazo commented Aug 23, 2020

@mikhailredis Thank you for adding the "Fill Missing" field to TS.RANGE queries.

This commit applies the same logic to TS.MRANGE queries where I've found it to be useful as well. Screenshots of before/after below:

Before
Screenshot from 2020-08-23 10-21-33

After
Screenshot from 2020-08-23 10-21-46

I haven't written much go before -- please let me know if there are style/syntax things missing here and I'm happy to correct them. Also happy to hand off the branch to get it fixed up and merged in.

Thanks again!

@mikhail-vl mikhail-vl self-assigned this Aug 23, 2020
@mikhail-vl mikhail-vl added the enhancement New feature or request label Aug 23, 2020
@mikhail-vl mikhail-vl added this to the Version 1.2 milestone Aug 23, 2020
@mikhail-vl
Copy link
Contributor

@dpipemazo Thank you for the pull request! I will test and review shortly.

Please share your dashboards and results when finish your project.

@mikhail-vl mikhail-vl self-requested a review August 23, 2020 17:33
Copy link
Contributor

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mikhail-vl mikhail-vl merged commit d0476c2 into RedisGrafana:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants