Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-allocate the results size in Graph ResultSetBuilder #144

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Pre-allocate the results size in Graph ResultSetBuilder #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 32 additions & 31 deletions src/main/java/com/redislabs/redisgraph/impl/resultset/ResultSetImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,42 +63,43 @@ public ResultSetImpl(List<Object> rawResponse, RedisGraph redisGraph, GraphCache
*/
@SuppressWarnings("unchecked")
private List<Record> parseResult(List<List<Object>> rawResultSet) {
List<Record> results = new ArrayList<>();
if (rawResultSet == null || rawResultSet.isEmpty()) {
return results;
} else {
// go over each raw result
for (List<Object> row : rawResultSet) {

List<Object> parsedRow = new ArrayList<>(row.size());
// go over each object in the result
for (int i = 0; i < row.size(); i++) {
// get raw representation of the object
List<Object> obj = (List<Object>) row.get(i);
// get object type
Header.ResultSetColumnTypes objType = header.getSchemaTypes().get(i);
// deserialize according to type and
switch (objType) {
case COLUMN_NODE:
parsedRow.add(deserializeNode(obj));
break;
case COLUMN_RELATION:
parsedRow.add(deserializeEdge(obj));
break;
case COLUMN_SCALAR:
parsedRow.add(deserializeScalar(obj));
break;
default:
parsedRow.add(null);
break;
}
return new ArrayList<>(0);
}

List<Record> results = new ArrayList<>(rawResultSet.size());
// go over each raw result
for (List<Object> row : rawResultSet) {

List<Object> parsedRow = new ArrayList<>(row.size());
// go over each object in the result
for (int i = 0; i < row.size(); i++) {
// get raw representation of the object
List<Object> obj = (List<Object>) row.get(i);
// get object type
Header.ResultSetColumnTypes objType = header.getSchemaTypes().get(i);
// deserialize according to type and
switch (objType) {
case COLUMN_NODE:
parsedRow.add(deserializeNode(obj));
break;
case COLUMN_RELATION:
parsedRow.add(deserializeEdge(obj));
break;
case COLUMN_SCALAR:
parsedRow.add(deserializeScalar(obj));
break;
default:
parsedRow.add(null);
break;
}
// create new record from deserialized objects
Record record = new RecordImpl(header.getSchemaNames(), parsedRow);
results.add(record);
}

// create new record from deserialized objects
Record record = new RecordImpl(header.getSchemaNames(), parsedRow);
results.add(record);
}

return results;
}

Expand Down