Skip to content

hiredis as a dependency #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021
Merged

hiredis as a dependency #131

merged 1 commit into from
Jun 1, 2021

Conversation

swilly22
Copy link
Contributor

@swilly22 swilly22 commented Jun 1, 2021

Resolves #86

@swilly22 swilly22 added the bug label Jun 1, 2021
@swilly22 swilly22 requested a review from chayim June 1, 2021 06:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #131 (a1e013e) into master (9524b31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files           8        8           
  Lines         521      521           
=======================================
  Hits          445      445           
  Misses         76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9524b31...a1e013e. Read the comment docs.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Did you add this via poetry add, or edit the file? One of the beautiful features of poetry is that the command does the work for us now.

@swilly22
Copy link
Contributor Author

swilly22 commented Jun 1, 2021

@chayim not familiar with toml commands, I've edited the file manually

@swilly22 swilly22 merged commit eff17ac into master Jun 1, 2021
@swilly22 swilly22 deleted the hiredis-dep branch June 1, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for nested multi bulk replies with depth > 7
2 participants