add multi label support #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilly22
suggested changes
Oct 17, 2021
swilly22
suggested changes
Oct 18, 2021
swilly22
suggested changes
Oct 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 85.66% 86.18% +0.52%
==========================================
Files 8 8
Lines 530 543 +13
==========================================
+ Hits 454 468 +14
+ Misses 76 75 -1
Continue to review full report at Codecov.
|
swilly22
suggested changes
Oct 21, 2021
redisgraph/node.py
Outdated
| @@ -11,7 +11,17 @@ def __init__(self, node_id=None, alias=None, label=None, properties=None): | |||
| """ | |||
| self.id = node_id | |||
| self.alias = alias | |||
| self.label = label | |||
| if label is None or (isinstance(label, list) and len(label) == 0): | |||
There was a problem hiding this comment.
handle the case where label = ""
|
Kudos, SonarCloud Quality Gate passed!
|
swilly22
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.