define __all__ #95
Merged
define __all__ #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define __all__ to make sure `from .util import *` won't polute the globals
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 84.95% 84.98% +0.02%
==========================================
Files 8 8
Lines 585 586 +1
==========================================
+ Hits 497 498 +1
Misses 88 88
Continue to review full report at Codecov.
|
|
This pull request fixes 3 alerts when merging ac8002f into 5680907 - view on LGTM.com fixed alerts:
|
swilly22
suggested changes
Oct 18, 2020
| @@ -1,6 +1,8 @@ | |||
| import random | |||
| import string | |||
|
|
|||
| __all__ = ['random_string', 'quote_string'] | |||
There was a problem hiding this comment.
Why is this necessary ?
when importing everything from this module (util.py) the importer will get random_string and quote_string by default.
There was a problem hiding this comment.
|
This pull request fixes 3 alerts when merging 32959bd into d06449f - view on LGTM.com fixed alerts:
|
swilly22
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define all to make sure
from .util import *won't polute the globals