Skip to content

JSON.TOGGLE and JSON.CLEAR #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 9, 2021
Merged

JSON.TOGGLE and JSON.CLEAR #55

merged 10 commits into from
Aug 9, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Aug 5, 2021 •
edited
Loading

Also added here support for JSON.DEBUG MEMORY

@AvitalFineRedis AvitalFineRedis linked an issue Aug 5, 2021 that may be closed by this pull request
Support json.toggle and json.clear commands #50
Closed
@AvitalFineRedis
JSON.DEBUG
b72bfe0
@AvitalFineRedis
Merge remote-tracking branch 'origin/json.toggle_and_json.clear' into…
528064f 
… json.toggle_and_json.clear

# Conflicts:
#	tests/test_rejson.py
oshadmi
oshadmi reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Looks good, just minor comments

AvitalFineRedis and others added 3 commits August 9, 2021 08:55
@AvitalFineRedis @oshadmi
Update tests/test_rejson.py
357b7bd 
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
@AvitalFineRedis
check non-boolean value
609bc70
@AvitalFineRedis
change assert raise
f5272a1
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AvitalFineRedis AvitalFineRedis mentioned this pull request Aug 9, 2021
Closed
oshadmi
oshadmi approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@AvitalFineRedis AvitalFineRedis merged commit 235d658 into master Aug 9, 2021
@AvitalFineRedis AvitalFineRedis deleted the json.toggle_and_json.clear branch August 9, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadmi oshadmi oshadmi approved these changes

@chayim chayim Awaiting requested review from chayim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support json.toggle and json.clear commands
2 participants
@AvitalFineRedis @oshadmi