Fix crash in proxy cluster update #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domrod
pushed a commit
to domrod/redis-cluster-proxy
that referenced
this pull request
Apr 3, 2022
domrod
added a commit
to domrod/redis-cluster-proxy
that referenced
this pull request
Apr 3, 2022
* Apply merge request RedisLabs#98 From RedisLabs#98 * Apply Merge Request RedisLabs#82 From RedisLabs#82 * Apply Merge Request RedisLabs#67 From RedisLabs#67 * Set optimization in makefile to -O3 * Add a Dockerfile for tests and set a version Co-authored-by: Dominique Rodrigues <dominique.rodrigues@paymium.com>
domrod
added a commit
to domrod/redis-cluster-proxy
that referenced
this pull request
Apr 3, 2022
* Apply several pull requests from project (#1) * Apply merge request RedisLabs#98 From RedisLabs#98 * Apply Merge Request RedisLabs#82 From RedisLabs#82 * Apply Merge Request RedisLabs#67 From RedisLabs#67 * Set optimization in makefile to -O3 * Add a Dockerfile for tests and set a version Co-authored-by: Dominique Rodrigues <dominique.rodrigues@paymium.com> * Forgotten file Dockerfile.tests added (#2) Co-authored-by: Dominique Rodrigues <dominique.rodrigues@paymium.com> Co-authored-by: Dominique Rodrigues <dominique.rodrigues@paymium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
The problem appears to be that
resetClusterdoes not nullcluster->master_names, resulting in a double free whenproxy cluster updateis called twice.Calling
clusterGetMasterNameswas not strictly necessary but it seemed like the right thing to do to ensure the cluster struct is fully recreated by the update.