Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rladmin reference (Doc-83, DOC-210, DOC-606) #1256

Merged
merged 34 commits into from
Mar 17, 2021
Merged

rladmin reference (Doc-83, DOC-210, DOC-606) #1256

merged 34 commits into from
Mar 17, 2021

Conversation

kaitlynmichael
Copy link
Contributor

No description provided.

@kaitlynmichael kaitlynmichael self-assigned this Mar 3, 2021
@AlonMagrafta
Copy link
Contributor

@kaitlynmichaelredislabs - While I review this, how are we planning on keeping this up-to-date?

@kaitlynmichael
Copy link
Contributor Author

@AlonMagrafta we want any public documentation to always be up-to-date. I already know this page is missing rladmin cluster config saslauthd_ldap_conf. I've created DOC-606 to track that.

@kaitlynmichael kaitlynmichael changed the title Doc 83 rladmin rladmin reference (Doc-83, DOC-210) Mar 5, 2021
@kaitlynmichael kaitlynmichael changed the title rladmin reference (Doc-83, DOC-210) rladmin reference (Doc-83, DOC-210, DOC-606) Mar 5, 2021
@kaitlynmichael
Copy link
Contributor Author

Please try to find time to review this PR this week; I am aiming to merge this on Friday 3/12.

amiramm
amiramm requested changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@amiramm amiramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this! I've made some comments, mostly around how we approach this type of document - you may have already discussed this offline.

content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Outdated Show resolved Hide resolved
AlonMagrafta
AlonMagrafta requested changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@AlonMagrafta AlonMagrafta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of lines 1-300

content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Outdated Show resolved Hide resolved
content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md
`rladmin cluster config` updates the cluster configuration.

```text
rladmin cluster config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual order is different + few new ones (16,18,19):

  1. cipher_suites
  2. cm_port
  3. cm_session_timeout_minutes
  4. cnm_http_port
  5. cnm_https_port
  6. data_cipher_list
  7. debuginfo_path
  8. handle_redirects
  9. http_support
  10. ipv6
  11. min_control_TLS_version
  12. min_data_TLS_version
  13. min_sentinel_TLS_version
  14. s3_url
  15. saslauthd_ldap_conf
  16. sentinel_cipher_suites
  17. sentinel_ssl_policy
  18. services
  19. upgrade_mode <enabled/disabled> (Alon: I must say I'm not sure yet what that is)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlonMagrafta Do you have the arguments and descriptions for sentinel_cipher_suites, services, upgrade_mode?

content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md Show resolved Hide resolved
content/rs/references/rladmin.md
rladmin cluster services [ cm_server | crdb_coordinator | crdb_worker | mdns_server | pdns_server | saslauthd | stats_archiver <enabled | disabled> ]
```

### `failover`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlonMagrafta : Mark to myself, I reviewed this PR to this point, not including the extended part of cluster create+recover+join

kaitlynmichael and others added 6 commits March 15, 2021 14:00
@kaitlynmichael @amiramm
Update content/rs/references/rladmin.md
546a796 
Co-authored-by: Amiram Mizne <amiramm@users.noreply.github.com>
@kaitlynmichael
Update content/rs/references/rladmin.md
1781542
@kaitlynmichael @AlonMagrafta
Update content/rs/references/rladmin.md
7699b68 
Co-authored-by: Alon Magrafta <50071256+AlonMagrafta@users.noreply.github.com>
@kaitlynmichael @AlonMagrafta
Update content/rs/references/rladmin.md
63ae274 
Co-authored-by: Alon Magrafta <50071256+AlonMagrafta@users.noreply.github.com>
@kaitlynmichael
cluster config
229d53b
@kaitlynmichael
removed cluster config services until I verify
e7836c5
@kaitlynmichael kaitlynmichael merged commit d512b16 into master Mar 17, 2021
@kaitlynmichael kaitlynmichael deleted the DOC-83-rladmin branch March 17, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiramm amiramm amiramm requested changes

@AlonMagrafta AlonMagrafta AlonMagrafta requested changes

@banker banker Awaiting requested review from banker

@lanceleonard lanceleonard Awaiting requested review from lanceleonard

@ushachar ushachar Awaiting requested review from ushachar

Assignees

@kaitlynmichael kaitlynmichael

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaitlynmichael @AlonMagrafta @amiramm