Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc-646 TLS revision #1296

Merged
merged 19 commits into from
Apr 1, 2021
Merged

Doc-646 TLS revision #1296

merged 19 commits into from
Apr 1, 2021

Conversation

kaitlynmichael
Copy link
Contributor

No description provided.

banker
banker previously requested changes Mar 30, 2021
Copy link
Contributor

@banker banker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but overall looking good!

content/rs/security/tls-ssl.md Outdated Show resolved Hide resolved
content/rs/security/tls-ssl.md Outdated Show resolved Hide resolved
content/rs/security/tls-ssl.md Outdated Show resolved Hide resolved
content/rs/security/tls-ssl.md Outdated Show resolved Hide resolved
content/rs/security/tls-ssl.md Show resolved Hide resolved
content/rs/security/tls-ssl.md Show resolved Hide resolved
content/rs/security/tls-ssl.md Outdated Show resolved Hide resolved
content/rs/security/tls-ssl.md Outdated Show resolved Hide resolved
content/rs/security/tls-ssl.md Show resolved Hide resolved
Copy link
Contributor

@AlonMagrafta AlonMagrafta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's even pretty simple and easy to read and follow.
I agree with Kyle's review and comments, so we have just small changes to apply. I left individual comments along the page.
Thanks!

kaitlynmichael and others added 2 commits March 31, 2021 09:33
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
@kaitlynmichael kaitlynmichael self-assigned this Mar 31, 2021
@kaitlynmichael kaitlynmichael dismissed banker’s stale review April 1, 2021 15:53

All comments addressed

@kaitlynmichael kaitlynmichael merged commit 1103004 into release-6.0.20 Apr 1, 2021
@kaitlynmichael kaitlynmichael deleted the DOC-646 branch April 1, 2021 15:53
lanceleonard added a commit that referenced this pull request Apr 13, 2021
* DOC-390 Add data eviction to Active-Active database creation procedure (#1171)

* deprecation of featureset and protocol version 0

part of 6.0.20.
Was mentioned on RN of 6.0.12 and will also be part of 6.0.20 RN

* Update upgrading.md (#1267)

* Doc 390 eviction for active active (#1268)

* DOC-525 Migrate to Active-Active with Replica Of (#1208)

* no-AA-eviction-RoF.md (#1281)

* Doc-89 priority mTLS changes for 6.0.20 (#1293)

* security changes
* changes to mTLS cert add process

* Doc-646 TLS revision (#1296)

* Jira DOC-306: Document LDAP support in new release (#1289)

* Initial check-in.  Need images and edit.

* Updating links to location for cluster ldap doc.

* Adding screenshots and performing initial edit pass.

* Additional edits, links, and minor tweaks.

* Changes for editorial feedback.

* Fixing broken link

* Fixing tpyo in broken link fix

* Fixing tpyo in the typo fix for the broken link fix.

* Update cluster-based-ldap-authentication.md

* More feedback updates.

Co-authored-by: Kyle Banker <kyle.banker@redislabs.com>
Co-authored-by: Alon Magrafta <50071256+AlonMagrafta@users.noreply.github.com>

* Initial check-in of Azure SAS support notes; also includes high level edits for new style guidelines. (#1301)

* cipher suite options for cluster config (#1314)

* DOC-392 A/A support for bitfield (#1300)

* RS v6.0.20 release notes (#1316)

* Follow-up to PR #1231; fixing assorted minor issues  (#1311)

* First set of quick fixes.

* More edits and updates, mainly to redirects.

* Updating python library to be more current.

* Updating backup article aliases (#1315)

* First set of quick fixes.

* More edits and updates, mainly to redirects.

* Updating python library to be more current.

* Updating aliases

* Initial draft for release notes

Co-authored-by: Ben Mansheim <github@mansheim.com>
Co-authored-by: Alon Magrafta <50071256+AlonMagrafta@users.noreply.github.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichaelredislabs@users.noreply.github.com>
Co-authored-by: Kyle Banker <kyle.banker@redislabs.com>
Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com>
Co-authored-by: kaitlyn.michael <kaitlyn.michael@redislabs.com>
Co-authored-by: Kyle Banker <banker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants