DOC-994 Istio ingress configuration

[kaitlynmichael]

DOC-994
Staging: https://docs.redis.com/staging/jira-doc-994/kubernetes/re-databases/ingress_routing_with_istio/

based off: https://redislabs.atlassian.net/wiki/spaces/K8s/pages/3199008780/Istio+as+an+Ingress+controller+-+Installation+configuration+and+accessing+a+Redis+Enterprise+database+from+outside+the+K8S+cluster

[laurentdroin]

The IP addresses have an invalid format. For example, 12.345.678.910 will strike people as invalid since values would be <= 255 for ipv4. I know that it shouldn't matter since they are not supposed to be used as-is anyway but still, I can guarantee this will annoy many nerds, not just me :-)

[laurentdroin]

v1alpha3 is old, let's not use it for the istio resources (I know it's all over the official istio examples but still).
Instead, we should go with "networking.istio.io/v1beta1"

[laurentdroin]

I think that the following:

"The gateway’s metadata name must be similar to the gateway’s spec name (redis-gateway in this example)."

is misplaced. It would make some sense if the Gateway came second in the list of Istio resources but it comes first.

I believe that what we mean is the following:

The 'gateway listed in the "gateways" spec of the VirtualService resource must correspond to the name of the Gateway resource'
And for this to make sense, we need to have introduced both resources (i.e. we can't put this text in between resources).

Or something similar to the above... We just need to explain the link between the 2 resources.

[laurentdroin]

I don't know if we are making it clear that with the VirtualService example, we are actually creating both a route to contact the API server and a route to contact one of the databases. A reader might wonder where is "db1" coming from so we may want to explain this a bit more.
And if we are just explaining how to access the databases, do we really need to bother with a route for the API?

[bascar]

v1alpha3 is old, let's not use it for the istio resources (I know it's all over the official istio examples but still). Instead, we should go with "networking.istio.io/v1beta1"

Have we tested against v1beta1?

[laurentdroin]

v1alpha3 is old, let's not use it for the istio resources (I know it's all over the official istio examples but still). Instead, we should go with "networking.istio.io/v1beta1"

Have we tested against v1beta1?

Not that it's official, but I have.

[laurentdroin]

@bascar Looks like there is no difference between v1alpha3 and v1beta1 - just better to go with the latest version.

See: https://discuss.istio.io/t/is-api-version-networking-istio-io-v1alpha3-considered-to-be-deprecated-on-1-5-0/7278

And that was 1.5 years ago, so we definitely should use v1beta1 IMO.

[kaitlynmichael]

New edits from feedback:

• new example IPs
• replaced v1alpha3 with v1beta1
• moved gateway metadata explanation after virtual service yaml
• added note after vs example about creating route for API and db

[rrelledge]

Looks good to me. I just left a few suggestions.