Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC: Presenting the new Fixed limitation per plan in our Docs #3137

Merged
merged 14 commits into from
Mar 12, 2024
Merged

Conversation

cmilesb
Copy link
Contributor

@cmilesb cmilesb commented Feb 20, 2024

Copy link
Contributor

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@shai-maskit
Copy link

@cmilesb several comments:

  1. I'd like to think of a different word for instead of "tier", since it is already used as part of the "Auto-tiering" brand. One suggestion is just to use "Plan".
    Here how it'll play out, i hope it's not interfering with other sections of the documentation:

Fixed Size subscription plans support low throughput workflows. Several tiers are available, each designed for different memory sizes and integration requirements.

-->
Fixed subscription plans support low throughput workflows. Several plans are available, each designed for different memory sizes and integration requirements.

When creating your subscription, you’ll need to know which tier to choose.

-->
When creating your subscription, you’ll need to choose the plan which suits your needs

Fixed plan subscription tiers
--> Fixed plans

Fixed plan pricing scales
--> Fixed plans pricing scale

  1. not sure what you meant by "integration requirements"?

each designed for different memory sizes and integration requirements

  1. In the tables, I suggest to add an asterisk next to "maximum throughout" , and add a footnote under the table itself otherwise users (such as myself 😄 ) won't realize there's one at the bottom of the page. If you want to keep the existing footnote as well, I'll probably want to rephrase it..
    --> * Assumes request size of 1KiB. Maximums are capped by actual MB/s reached

  2. Not sure if it's only in my screen, but the 30MB plan has 100 ops/sec in the same line while all the other plans have ops/sec in the second line

  3. we need to have also reference for older plans that most of users are still using. It can be in a sub page, and we need to provide a message somewhere in the lines of "Legacy plans". These are the 100MB, 500MB plans. Or, we can include them in the existing tables are marked them as legacy. Up to you @cmilesb

  4. in the image of "Select the desired plan size", let's have real prices there instead of X's

  5. When talking about the replication options, i want us to think on how to convey the message that the "DB size" includes the memory for replication. Yes, we'll address it in more depth in the "dataset size" feature but we can already do something here. One option could be in the table:

Max DB size
--> DB size (including the replica where applicable)

@Carmel-S
Copy link

Hey there!
Just took a look at https://docs.redis.com/staging/DOC-3369/rc/subscriptions/create-fixed-subscription/#fixed-plans. I think it's a bit confusing that we talk about fixed plans and fixed subscriptions on the same page. I know it's the nature of our product but could be helpful to call out the hierarchy and the fact that subscriptions sit within plans :)

@cmilesb
Copy link
Contributor Author

cmilesb commented Mar 12, 2024

@Carmel-S I created DOC-3523 to track this work separately, since this PR has been in limbo for a while and I'd like to publish it.

@cmilesb cmilesb merged commit a85fe5d into master Mar 12, 2024
6 checks passed
@cmilesb cmilesb deleted the DOC-3369 branch March 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants