RC: Throughput section changes #3174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmilesb
requested review from
AlonMagrafta,
NoamSternRedis,
dwdougherty,
kaitlynmichael,
mich-elle-luna and
rrelledge
AlonMagrafta
requested changes
Mar 6, 2024
| We assume a typical workload that includes a different mix of commands and an average key and value size of 1KB. Therefore, your actual throughput be higher or lower than the throughput you set when you create your database. The following properties can affect your database's throughput: | ||
| - **Command complexity**: O(N) and O(log(N)) commands will take more time than O(1) commands, and will affect throughput accordingly. | ||
| - **Key and value sizing**: If your database's keys and values are very large, setting and reading those keys may take more time and affect throughput. | ||
| - **Key and value sizing**: If your database's keys and values are very large, setting and reading those keys may take more time and affect throughput. If these are lower than the typical workload, the actual throughput might be higher than expected. |
AlonMagrafta
previously requested changes
Mar 6, 2024
Contributor
|
Other than my comment to @NoamSternRedis - LGTM now :) |
cmilesb
commented
Mar 11, 2024
mich-elle-luna
approved these changes
Mar 13, 2024
Contributor
mich-elle-luna
left a comment
mich-elle-luna
left a comment
There was a problem hiding this comment.
Thank you, just one suggestion for clarity, to qualify "these" and align the word (smaller versus larger) with the previous sentence. But, it is up to you if that makes sense.
Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-3492
Staging link: https://docs.redis.com/staging/DOC-3492/rc/databases/create-database#throughput