-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC Packaging: Split create databases into 3 and implement Essentials flow #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmilesb
requested review from
dwdougherty,
kaitlynmichael,
rrelledge and
mich-elle-luna
March 20, 2024 17:17
mich-elle-luna
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! just a few typos and changes for precision/clarity.
content/rc/databases/create-database/create-essentials-database.md
Outdated
Show resolved
Hide resolved
content/rc/databases/create-database/create-essentials-database.md
Outdated
Show resolved
Hide resolved
content/rc/databases/create-database/create-pro-database-existing.md
Outdated
Show resolved
Hide resolved
content/rc/databases/create-database/create-pro-database-existing.md
Outdated
Show resolved
Hide resolved
content/rc/databases/create-database/create-pro-database-existing.md
Outdated
Show resolved
Hide resolved
content/rc/databases/create-database/create-pro-database-new.md
Outdated
Show resolved
Hide resolved
content/rc/databases/create-database/create-pro-database-new.md
Outdated
Show resolved
Hide resolved
Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
mich-elle-luna
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
* Databases landing page * Apply suggestions from code review Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> --------- Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com>
cmilesb
added a commit
that referenced
this pull request
Mar 28, 2024
* Fixed on GCP changes * Changed Fixed and Flexible to Essentials and Pro except where already changed * marketplace integrations * RC Packaging: Quick Start (#3201) * Quick start changes * remove subscription and edit signup image * Update content/rc/rc-quickstart.md * RC Packaging: Split create databases into 3 and implement Essentials flow (#3203) * create database - first draft * Typo and links * split create db into 3 * Screenshots for Essentials * DOC-3459 Remove shards note for search and query * create database - first draft * more throughput changes * Revert previous commit * Apply suggestions from code review Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> * RC New Packaging: Databases landing page (#3205) * Databases landing page * Apply suggestions from code review Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> --------- Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> --------- Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> * RC Packaging: View and Edit databases (#3204) * Edit with packaging changes * Apply suggestions from code review Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> --------- Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> * fix build error * Fix small image * RC New packaging: Create Pro databases (#3219) * First draft * Bedrock changes * RC New Packaging: Remove Create Subscription pages (#3211) * Remove Create Flexible and Create Active-Active subscriptions * fix build errors * Remove create Fixed and rename files * Fix build errors/alias issues * change titles/linktitles * Edit index page * Move Essentials first * RC New Packaging: Create Active-Active database (#3217) * Remove Create Flexible and Create Active-Active subscriptions * fix build errors * Remove create Fixed and rename files * Fix build errors/alias issues * change titles/linktitles * Edit index page * Move Essentials first * Active-Active databases and move A/A to configure * Index pages and links * Databases section minor updates (#3221) * Fix image size * Remove old logo link * image fixes * Update content/rc/cloud-integrations/aws-marketplace/aws-bedrock/set-up-redis.md * Update content/rc/subscriptions/view-essentials-subscription/essentials-plan-details.md Co-authored-by: David Dougherty <david.dougherty@redis.com> * RC: Throughput moving to ops/sec for search & query changelog updates (#3218) * ops/sec changelog * Remove breaking change * Add deprecation --------- Co-authored-by: mich-elle-luna <153109578+mich-elle-luna@users.noreply.github.com> Co-authored-by: David Dougherty <david.dougherty@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-3391, DOC-3459, DOC-3527
Staging links:
https://docs.redis.com/staging/DOC-3391/rc/databases/create-database/
https://docs.redis.com/staging/DOC-3391/rc/databases/create-database/create-essentials-database/
The Pro database pages are there, but not done yet since the flow hasn't been fully implemented yet.