Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specification of decode_responses in Env #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafie
Copy link
Contributor

@rafie rafie commented Aug 22, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #128 (6bb574b) into master (44dcbcd) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   37.57%   37.55%   -0.02%     
==========================================
  Files          17       17              
  Lines        2092     2093       +1     
==========================================
  Hits          786      786              
- Misses       1306     1307       +1     
Flag Coverage Δ
unittests 37.55% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
RLTest/exists_redis.py 39.75% <33.33%> (-0.49%) ⬇️
RLTest/env.py 57.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44dcbcd...6bb574b. Read the comment docs.

@@ -152,7 +152,7 @@ def getKwargs(self):
class Env:
RTestInstance = None
EnvCompareParams = ['module', 'moduleArgs', 'env', 'useSlaves', 'shardsCount', 'useAof',
'useRdbPreamble', 'forceTcp']
'useRdbPreamble', 'forceTcp', 'decodeResponses']
Copy link
Collaborator

@MeirShpilraien MeirShpilraien Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it should be part of the env definition, we could make it an argument to env.cmd/env.expect/env.getConnection .. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants