Allow setting no modules in env #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets all the unsafe flags togather
MeirShpilraien
approved these changes
Nov 21, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 34.05% 34.12% +0.06%
==========================================
Files 17 17
Lines 2393 2403 +10
==========================================
+ Hits 815 820 +5
- Misses 1578 1583 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By sending an empty list, allow creating an env that contains no modules using
env = Env(module=[])(until today there was no such possibility) - this is meant for testing situations where we want to load the module during in test.Also, allow using
MODULEcommands in redis by setting--enable-module-command yeswhenever the new--enable-module-commandflag is set, and add another--allow-unsafeflag that enables--enable-debug-command,--enable-protected-config, and--enable-module-commandall together.