Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cwd in redis process #219

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Set cwd in redis process #219

merged 1 commit into from
Jan 16, 2024

Conversation

alonre24
Copy link
Collaborator

@alonre24 alonre24 commented Jan 16, 2024

Set cwd upon launching redis subprocess to be the logs dir rather than using the --dir configuration to set the current dir.
The motivation for that is when running sanitizer which instruments redis process, the sanitizer creates its log in cwd BEFORE redis initializes and sets cwd according to the --dir configuration. With this change, we can guarantee that logs will always be created in the logs path.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55f3ff0) 32.41% compared to head (0d96398) 32.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   32.41%   32.36%   -0.06%     
==========================================
  Files          17       17              
  Lines        2588     2586       -2     
==========================================
- Hits          839      837       -2     
  Misses       1749     1749              
Flag Coverage Δ
unittests 32.36% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonre24 alonre24 merged commit da43a25 into master Jan 16, 2024
23 checks passed
@alonre24 alonre24 deleted the set_cwd_in_proccess branch January 16, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants