Add support to delete hash fields #130
Conversation
| // see https://github.com/redis/redis/issues/7860 | ||
|
|
||
| unsafe { | ||
| RedisModule_HashSet.unwrap()( |
There was a problem hiding this comment.
It seems like the RedisModule_HashSet C API has been overloaded with multiple things and it does a lot more than merely setting a hash value.
I'm very new to Rust. I don't know where to draw the line between this project providing a user-friendly Rust API to modules vs this project being a very thin and pass-through wrapper around the C modules API. Does it make sense to extend hash_set to take a additional flags/options instead?
There was a problem hiding this comment.
The aim of this module is to provide an idiomatic Rust API for the Redis modules API. Using flag arguments to fundamentally change the functionality of a method isn't very common even in C, doubly so in Rust; so I think the approach you took here is the right one.
One thing I would change is rename all the instances of hash_del_single to simply hash_del, to match the existing style of hash_set/hash_get.
Oh, and thank you for the PR!
src/raw.rs
Outdated
| // support to pass multiple fields is desired but it's complicated | ||
| // see https://github.com/redis/redis/issues/7860 |
There was a problem hiding this comment.
Indeed; if we want to support multiple fields we should use a macro-based solution like we did for hash_get_multi.
| @@ -156,6 +156,7 @@ extern "C" { | |||
| /////////////////////////////////////////////////////////////// | |||
|
|
|||
| pub const FMT: *const c_char = b"v\0".as_ptr() as *const c_char; | |||
| pub const REDISMODULE_HASH_DELETE: *const RedisModuleString = 1 as *const RedisModuleString; | |||
There was a problem hiding this comment.
I tried to figure out why this was needed -- I expected bindgen to generate this automatically.
It turns out it doesn't because it can't parse the typecast, see rust-lang/rust-bindgen#316.
Please add a comment here that mentions this.
prashanthpai
force-pushed
the
add-hash-del-single
branch
from
d6c427f
to
3e8b9e6
Compare
No description provided.