Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bindgen's parse_callbacks to avoid ugly explicit casts #88

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

gavrie
Copy link
Contributor

@gavrie gavrie commented Jun 15, 2020

No description provided.

Copy link
Contributor

@yoav-steinberg yoav-steinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice cleanup.

@gavrie gavrie merged commit 8a8ca6d into add_support_for_server_events Jun 17, 2020
@gavrie gavrie deleted the bindgen_cleanups branch June 17, 2020 12:00
gkorland pushed a commit that referenced this pull request Jun 24, 2020
* Update to latest redis 6 redismodule.h, no need to use the hacked redismodule.h from RediSearch.

* Remove all API calls that use long double, this is because of and issue in bindgen: rust-lang/rust-bindgen#1549

* Added support for server events API.

* Remove "static" from global const event id structs so they can be accessed from outside the c code.

* cleanup

* Use bindgen's parse_callbacks to avoid ugly explicit casts (#88)

Co-authored-by: Gavrie Philipson <gavrie@redislabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants