Basic commands #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkorland
suggested changes
Jan 10, 2020
| # TS.CREATE key [RETENTION retentionTime] [UNCOMPRESSED] [LABELS field value..] | ||
| function create(conn::RedisConnection, key::String, command::String) | ||
| response = execute_command(conn, ["TS.CREATE", key, command]) | ||
| println(response) |
There was a problem hiding this comment.
@jeffreylovitz I think it's better to remove the println and return status
| # TS.ALTER key [RETENTION retentionTime] [LABELS field value..] | ||
| function alter(conn::RedisConnection, key::String, params::String) | ||
| response = execute_command(conn, ["TS.ALTER", key, params]) | ||
| println(response) |
There was a problem hiding this comment.
@jeffreylovitz I think it's better to remove the println and return status
| label_str = "" | ||
| for i in keys(labels) label_str = string(label_str, "$i $(labels[i]) ") end | ||
| response = execute_command(conn, ["TS.ADD", key, string(timestamp), string(value), retention, label_str]) | ||
| println(response) |
There was a problem hiding this comment.
@jeffreylovitz I think it's better to remove the println and return timestamp
| # TS.ADD key timestamp value [RETENTION retentionTime] [UNCOMPRESSED] [LABELS field value..] | ||
| # Note that UNCOMPRESSED is unused in timeseries-py; we are following suit here. | ||
| response = execute_command(conn, ["TS.ADD", key, string(timestamp), string(value), retention]) | ||
| println(response) |
There was a problem hiding this comment.
@jeffreylovitz I think it's better to remove the println and return the timestamp
| function madd(conn::RedisConnection, ktv_tuple::Tuple{String, Int64, Float64}) | ||
| # TS.MADD key timestamp value [key timestamp value ...] | ||
| response = execute_command(conn, ["TS.MADD", ktv_unfold(ktv_tuple)]) | ||
| println(response) |
There was a problem hiding this comment.
@jeffreylovitz I think it's better to remove the println and return the timestamps
| Redis.del(conn, key) | ||
| RedisTimeSeries.create(conn, key, "RETENTION 60000 LABELS sensor_id 2 area_id 32") | ||
| RedisTimeSeries.alter(conn, key, "LABELS sensor_id 2 area_id 32 sub_area_id 15") | ||
| RedisTimeSeries.add(conn, key, 1548149180000, 26.0, Dict{String,String}("sensor_id" => "2", "area_id" => "32")) |
There was a problem hiding this comment.
@jeffreylovitz can you please convert it to a real test with assert so we can use is as a base for our future tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.