In-Progress Redistimeseries v1.4 support #10
Conversation
filipecosta90
force-pushed
the
master
branch
from
4687262 to
56292c5
Compare
filipecosta90
force-pushed
the
redistimeseries-v1.4
branch
from
3e990e8 to
3dbb994
Compare
…n a common format across targets
…datapoints progress...
…_load_redistimeseries/main.go ( different from redis spec )
…_load_redistimeseries/main.go ( different from redis spec )
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
|
||
| set -x | ||
|
|
||
| EXE_DIR=${EXE_DIR:-$(dirname $0)} |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| set -x | ||
|
|
||
| EXE_DIR=${EXE_DIR:-$(dirname $0)} | ||
| source ${EXE_DIR}/query_common.sh |
There was a problem hiding this comment.
SC1091: Not following: ./query_common.sh was not specified as input (see shellcheck -x).
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| EXE_DIR=${EXE_DIR:-$(dirname $0)} | ||
| source ${EXE_DIR}/query_common.sh | ||
| source ${EXE_DIR}/redistimeseries_common.sh |
There was a problem hiding this comment.
SC1091: Not following: ./redistimeseries_common.sh was not specified as input (see shellcheck -x).
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| set -x | ||
|
|
||
| EXE_DIR=${EXE_DIR:-$(dirname $0)} | ||
| source ${EXE_DIR}/query_common.sh |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| EXE_DIR=${EXE_DIR:-$(dirname $0)} | ||
| source ${EXE_DIR}/query_common.sh | ||
| source ${EXE_DIR}/redistimeseries_common.sh |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| mkdir -p ${BULK_DATA_DIR} | ||
|
|
||
| # Ensure queries dir is clean | ||
| rm -rf ${BULK_DATA_DIR}/queries_${USE_CASE}_${FORMAT}_${SCALE}* |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| SKIP_IF_EXISTS=${SKIP_IF_EXISTS:-"TRUE"} | ||
|
|
||
| # Ensure DATA DIR available | ||
| mkdir -p ${BULK_DATA_DIR} |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| mkdir -p ${BULK_DATA_DIR} | ||
|
|
||
| # Ensure queries dir is clean | ||
| rm -rf ${BULK_DATA_DIR}/queries_${USE_CASE}_${FORMAT}_${SCALE}* |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| mkdir -p ${BULK_DATA_DIR} | ||
|
|
||
| # Ensure queries dir is clean | ||
| rm -rf ${BULK_DATA_DIR}/queries_${USE_CASE}_${FORMAT}_${SCALE}* |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| QUERY_DATA_FILE_NAME="queries_${USE_CASE}_${FORMAT}_${SCALE}_${QUERY_TYPE}_${QUERIES}.dat" | ||
| echo "Generating ${QUERY_DATA_FILE_NAME}:" | ||
| ${EXE_FILE_NAME} \ | ||
| --format=${FORMAT} \ |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| mkdir -p ${BULK_DATA_DIR} | ||
|
|
||
| # Ensure queries dir is clean | ||
| rm -rf ${BULK_DATA_DIR}/queries_${USE_CASE}_${FORMAT}_${SCALE}* |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| echo "Generating ${QUERY_DATA_FILE_NAME}:" | ||
| ${EXE_FILE_NAME} \ | ||
| --format=${FORMAT} \ | ||
| --queries=${QUERIES} \ |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| ${EXE_FILE_NAME} \ | ||
| --format=${FORMAT} \ | ||
| --queries=${QUERIES} \ | ||
| --query-type=${QUERY_TYPE} \ |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| --queries=${QUERIES} \ | ||
| --query-type=${QUERY_TYPE} \ | ||
| --scale=${SCALE} \ | ||
| --seed=${SEED} \ |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| --scale=${SCALE} \ | ||
| --seed=${SEED} \ | ||
| --timestamp-start=${TS_START} \ | ||
| --timestamp-end=${TS_END} \ |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| --format=${FORMAT} \ | ||
| --queries=${QUERIES} \ | ||
| --query-type=${QUERY_TYPE} \ | ||
| --scale=${SCALE} \ |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| --query-type=${QUERY_TYPE} \ | ||
| --scale=${SCALE} \ | ||
| --seed=${SEED} \ | ||
| --timestamp-start=${TS_START} \ |
There was a problem hiding this comment.
SC2086: Double quote to prevent globbing and word splitting.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| type HTTPClientDoOptions struct { | ||
| Debug int | ||
| PrettyPrintResponses bool | ||
| chunkSize uint64 |
There was a problem hiding this comment.
structcheck: chunkSize is unused
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| Debug int | ||
| PrettyPrintResponses bool | ||
| chunkSize uint64 | ||
| database string |
There was a problem hiding this comment.
structcheck: database is unused
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| "github.com/timescale/tsbs/pkg/query" | ||
| ) | ||
|
|
||
| var bytesSlash = []byte("/") // heap optimization |
There was a problem hiding this comment.
unused: var bytesSlash is unused
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| ) | ||
|
|
||
| // allows for testing | ||
| var printFn = fmt.Printf |
There was a problem hiding this comment.
unused: var printFn is unused
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| var ( | ||
| questdbRESTEndPoint string | ||
| questdbILPBindTo string | ||
| doAbortOnExist bool |
There was a problem hiding this comment.
unused: var doAbortOnExist is unused
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| } | ||
|
|
||
| func normaliseField(fieldValue string) string { | ||
| m1 := regexp.MustCompile("^\\s+") |
There was a problem hiding this comment.
gosimple: S1007: should use raw string (...) with regexp.MustCompile to avoid having to escape twice
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| func normaliseField(fieldValue string) string { | ||
| m1 := regexp.MustCompile("^\\s+") | ||
| m2 := regexp.MustCompile("\\s+$") | ||
| m3 := regexp.MustCompile("\\s+") |
There was a problem hiding this comment.
gosimple: S1007: should use raw string (...) with regexp.MustCompile to avoid having to escape twice
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| keyName := fmt.Sprintf("%s%s", hostname, fieldName) | ||
|
|
||
| // if this key was already inserted and created, we don't to specify the labels again | ||
| if keysSoFar[keyName] == false { |
There was a problem hiding this comment.
gosimple: S1002: should omit comparison to bool constant, can be simplified to !keysSoFar[keyName]
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| func normaliseField(fieldValue string) string { | ||
| m1 := regexp.MustCompile("^\\s+") | ||
| m2 := regexp.MustCompile("\\s+$") |
There was a problem hiding this comment.
gosimple: S1007: should use raw string (...) with regexp.MustCompile to avoid having to escape twice
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| new_query = append(new_query, fmt.Sprintf("%d", ts)) | ||
| } | ||
| new_query = append(new_query, "FILTER") | ||
| for _, arg := range commandArgs[7 : len(commandArgs)-4] { |
There was a problem hiding this comment.
gosimple: S1011: should replace loop with new_query = append(new_query, commandArgs[7:len(commandArgs)-4]...)
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| func execQuery(uriRoot string, query string) (QueryResponse, error) { | ||
| var qr QueryResponse | ||
| if strings.HasSuffix(uriRoot, "/") { |
There was a problem hiding this comment.
gosimple: S1017: should replace this if statement with an unconditional strings.TrimSuffix
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| // NewHTTPClient creates a new HTTPClient. | ||
| func NewHTTPClient(host string) *HTTPClient { | ||
| if strings.HasSuffix(host, "/") { |
There was a problem hiding this comment.
gosimple: S1017: should replace this if statement with an unconditional strings.TrimSuffix
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| func execQuery(uriRoot string, query string) (QueryResponse, error) { | ||
| var qr QueryResponse | ||
| if strings.HasSuffix(uriRoot, "/") { |
There was a problem hiding this comment.
gosimple: S1017: should replace this if statement with an unconditional strings.TrimSuffix
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
No description provided.