Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested improvements to vendor extensions topic #1386

Merged

Conversation

swapnilogale
Copy link
Contributor

a. Refined content
b. Added a table of contents

a. Refined content
b. Added a table of contents
Copy link
Member

@adamaltman adamaltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Nice changes!

The table of contents rendered on one line when I clicked to view the page, and I wasn't sure the reason because the markdown looked fine to me.


<!-- TOC depthFrom:1 depthTo:6 withLinks:1 updateOnSave:1 orderedList:0 -->

- [ReDoc vendor extensions](#redoc-vendor-extensions)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this is rendering all in one line instead of like a nice TOC.

image

Maybe there needs to be a space at the end of each line? (I'm not actually sure)

docs/redoc-vendor-extensions.md Outdated Show resolved Hide resolved
Comment on lines 9 to 11
- [x-servers](#x-servers)
- [x-tagGroups](#x-taggroups)
- [How to use with Redoc](#how-to-use-with-redoc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason these aren't indented further than the one above it (even though it looks like they should be).

@swapnilogale
Copy link
Contributor Author

@adamaltman - Looks ok now

image

@adamaltman
Copy link
Member

Yes! Thank you.

@RomanHotsiy RomanHotsiy merged commit 0c782ec into Redocly:master Oct 13, 2020
@RomanHotsiy
Copy link
Member

Thanks @swapnilogale !

shelbys added a commit to shelbys/redoc that referenced this pull request Oct 20, 2020
* upstream/master:
  chore: Release 2.0.0-rc.44 🔖
  feat: new extensions hook PropertyDetailsCell + wrap property name into span
  chore: add .vscode to .gitignore (Redocly#1416)
  chore: fix tests
  chore: Release 2.0.0-rc.43 🔖
  fix: fix broken observable after mobx upgrade (Redocly#1415)
  chore: Release 2.0.0-rc.42 🔖
  chore: update test snapshot (Redocly#1414)
  chore: upgrade to mobx@6 (Redocly#1412)
  fix: make schema layout more responsive on small screen (Redocly#1411)
  docs: unqualify mobx version for react usage (Redocly#1380)
  fix: make samples accessible by keyboard (Redocly#1401)
  docs: improvements to vendor extensions topic (Redocly#1386)
  fix: hide dropdown input on IE 11 (Redocly#1403)
  feat: Dockerfile compatible with OpenShift (Redocly#1407) (Redocly#1408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants