Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move role to list item to meet ARIA spec #2228

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Move role to list item to meet ARIA spec
dagfs committed Dec 6, 2022
commit 6220ce3afcc657b9f4609cd179219235b6912ad3
2 changes: 1 addition & 1 deletion src/components/SideMenu/MenuItem.tsx
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@ export class MenuItem extends React.Component<MenuItemProps> {
render() {
const { item, withoutChildren } = this.props;
return (
<MenuItemLi onClick={this.activate} depth={item.depth} data-item-id={item.id}>
<MenuItemLi onClick={this.activate} depth={item.depth} data-item-id={item.id} role="menuitem">
{item.type === 'operation' ? (
<OperationMenuItemContent {...this.props} item={item as OperationModel} />
) : (
1 change: 0 additions & 1 deletion src/components/SideMenu/styled.elements.ts
Original file line number Diff line number Diff line change
@@ -125,7 +125,6 @@ export interface MenuItemLabelType {
}

export const MenuItemLabel = styled.label.attrs((props: MenuItemLabelType) => ({
role: 'menuitem',
className: classnames('-depth' + props.depth, {
active: props.active,
}),