WIP: Initial React rewrite #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shenghu
reviewed
Oct 16, 2017
package.json
Outdated
| "dev": "webpack-dashboard -- webpack-dev-server --hot", | ||
| "test": "jest", | ||
| "bundle": "webpack", | ||
| "bundle:prod": "webpack -p -env.prod", |
There was a problem hiding this comment.
"bundle:prod": "webpack -p -env.prod" should be "bundle:prod": "webpack -p --env.prod",
There was a problem hiding this comment.
Yes, I've noticed the same issue but haven't tried to fix it yet. Just CTRL+C worked just fine for me (bundle actually is built and emitted to dist folder, but webpack process is not terminated by some strange reason).
Would be great if you could investigate this!
There was a problem hiding this comment.
It hangs there trying to connect
engine.io-client:polling-xhr xhr open GET: http://127.0.0.1:9838/socket.io/?EIO=3&transport=polling&t=LyeIbN8&b64=1 +1ms
9838 is used by webpack-dashboard. But removing it from webpack.config.js/plugins, build process can complete.
- refactored usage of store so now <Redoc> is sync - other minor refactors
RomanHotsiy
force-pushed
the
react-rewrite
branch
from
bcc9bcc
to
08034dc
Compare
RomanHotsiy
force-pushed
the
react-rewrite
branch
from
e210e50
to
f993e9b
Compare
RomanHotsiy
force-pushed
the
react-rewrite
branch
from
edbe78a
to
03cc781
Compare
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge
#327
Initial react rewrite.
When I started this I thought it will be just viewlayer rewrite but it appeared to be complete rewrite.
This is not yet in the alpha stage as there are a few things to implement before.
Some architecture decisions:
Known issues before alpha:
Before release:
I could probably have missed something so feel free to clarify here.