Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview-docs reload is not working anymore #538

Closed
nbourguig opened this issue Jan 28, 2022 · 4 comments · Fixed by #673
Closed

preview-docs reload is not working anymore #538

nbourguig opened this issue Jan 28, 2022 · 4 comments · Fixed by #673
Assignees
Labels
c0 p3 Type: Bug Something isn't working

Comments

@nbourguig
Copy link

nbourguig commented Jan 28, 2022

Describe the bug
Reloading browser is not working when openapi-cli is installed globally.

To Reproduce
Steps to reproduce the behavior:

  1. Install openapi-cli globally
  2. Open any specs files using preview-docs command openapi preview-docs openapi.yaml
  3. Open the browser
  4. Change anything in the spec file
  5. Browser does not reload

Expected behavior
The browser should reload content when the file is edited.

Logs
Browser cannot load simplewebsocket.min.js and hot.js
image

openapi-cli Version(s)
1.0.0-beta.80

Node.js Version(s)
16.13.2

Additional context
After checking out, it seems that this recently introduced change is preventing the loading of the hot.js and simplewebsocket.min.js

Commenting out this specific code in the /lib folder resolves the issue.

@nbourguig nbourguig changed the title preview-docs reload not working preview-docs reload is not working anymore Jan 28, 2022
@CarltonHowell
Copy link

I'm seeing the same issue
Screen Shot 2022-03-17 at 1 44 12 PM

@zeghong
Copy link

zeghong commented Mar 26, 2022

I'm seeing the same issue as well.

@tatomyr
Copy link
Contributor

tatomyr commented Mar 29, 2022

Could only reproduce this with a published version of openapi-cli and not in local development environment.

@tatomyr tatomyr added Type: Bug Something isn't working p3 labels Mar 29, 2022
@adamaltman
Copy link
Member

I have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c0 p3 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants