fix: preview server hot reload #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHotsiy
approved these changes
May 6, 2022
tatomyr
approved these changes
May 6, 2022
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
BohdanPetryshyn
force-pushed
the
fix/preview-server-hot-reload
branch
from
69627f9 to
b8ca5a9
Compare
|
It would be good for this to be included in this release: #681 |
5 tasks
|
@adamaltman, It will be included, I'm about to merge the PR |
Signed-off-by: BohdanPetryshyn <b.y.petryshyn@gmail.com>
BohdanPetryshyn
force-pushed
the
fix/preview-server-hot-reload
branch
from
b8ca5a9 to
f842f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
This PR fixes preview server hot reloads for the
openapi-clipackage global installation.As @nbourguig has pointed out, the issue was introduced with #347. The check only allowed files from the
CWDto be served by the preview server while the scripts needed for hot reload were in the global installation directory. Now the check only applies to arbitrary files.Reference
closes #538
Check yourself
Security