Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links closes #1779 #1786

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

adamaltman
Copy link
Member

What/Why/How?

Fixes two broken links. These links don't exist.

Reference

Closes #1779

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@adamaltman adamaltman requested a review from a team as a code owner October 27, 2024 18:42
Copy link

changeset-bot bot commented Oct 27, 2024

⚠️ No Changeset found

Latest commit: 1ddb8e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 988.4 ± 37.7 949.0 1080.9 1.01 ± 0.04
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 977.5 ± 21.4 956.9 1027.3 1.00

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.58% 4993/6354
🟡 Branches 67.24% 2063/3068
🟡 Functions 73.01% 825/1130
🟡 Lines 78.87% 4711/5973

Test suite run success

810 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from 1ddb8e2

@lornajane
Copy link
Contributor

I think the content does exist though? Is it that we need to update the links to point to the new locations?

@lornajane
Copy link
Contributor

Never mind, looks like we removed the information about how to get these values so I agree that there's nowhere else to link to.

@lornajane lornajane merged commit 05d6fd3 into main Oct 28, 2024
41 checks passed
@lornajane lornajane deleted the aa/docs-fix-broken-push-links branch October 28, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken links on push command page
2 participants