Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc branding for new project name #14

Conversation

Tekisasu-JohnK
Copy link
Contributor

This changes various parts of the codebase to reflect the new project name. It is not complete, but always historically the first part of my own personal patchset after each rebase and fork of upstream.

There are still many portions I left untouched as I figure those in charge of the Redot sources are still setting them up due to the project being new. Things like in editor_node.cpp, URLs to forums, proposals, documentation, community and the donation page. I did change the reporting URL to reflect the new Redot Engine github repo however.

This patch also modified undocked script and shader editor windows to properly reflect the new project name.

In my own fork of Godot, I remove many of these menu options entirely for less clutter. Let me know if that is desirable and I can add.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave license for the maintainers, there's still a lot of confusion over what we can and can't do.

We can switch licenses but we have to reference the Godot license, this isn't a job for a PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is left in place. Only a string is added preceeding the original. Do you want me to remove that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, never mind. Thanks. I see what you're pointing out now. I'll adjust later tonight.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the new project name in the license notification in the About window per request.

version.py Outdated Show resolved Hide resolved
@Tekisasu-JohnK
Copy link
Contributor Author

Some outstanding issues still remaining,

In editor/editor_node.cpp:

  1. Is there interest in the project for having a website forum? If so we'll want to adjust the HELP_FORUM case.

  2. Is there interest in replicating the godot-proposals repo? If so we'll want to adjust the HELP_SUGGEST_A_FEATURE case.

  3. Where will the documentation be hosted, and will be be forked from godot-docs? It needs to be addressed in theHELP_SEND_DOCS_FEEDBACK case.

  4. When donations are accepted (as far as I know, the team is holding off on accepting donations until the project is more developed), we need to adjust the HELP_SUPPORT_GODOT_DEVELOPMENT case.


In core/SCsub:

  1. When docs are available and hosted, the URL for #define VERSION_DOCS_URL needs to be adjusted.

In editor/engine_update_label.cpp

  1. This was a new feature in Godot 4.3 where a hosted .json file is downloaded by the client to check for a new version. The URL needs to be changed: "http->request("https://godotengine.org/versions.json");"

For my own fork, I have it referencing https://dev.tekisasu.com/update/engine.json. Godot themselves use this: https://godotengine.org/versions.json


Mac dist changed needed:
misc/dist/macos_tools.app/Contents/Info.plist
misc/dist/macos_template.app/Contents/Info.plist


And finally, for graphical assets concerning the fork process, the following assets need to be modified with whatever art is decided on (kudos to all the logo and art suggestions btw!):

editor/icons/Godot.svg
editor/icons/Logo.svg
main/app_icon.png
main/splash.png
misc/dist/icon_console.svg
misc/dist/project_icon.svg
misc/dist/macos_template.app/Contents/Resources/icon.icns
misc/dist/macos_tools.app/Contents/Resources/Godot.icns
misc/dist/windows/godot.iss
platform/android/export/logo.svg
platform/windows/godot_console.svg
platform/windows/godot.ico

@Tekisasu-JohnK
Copy link
Contributor Author

I dig the new logo so much! Any chance someone can ping the artist to see if they'd also be interested in contributing graphics assets for the aforementioned files? I was going to try to message him directly, but I couldn't find them.

@Redot-Engine Redot-Engine deleted a comment Oct 6, 2024
Copy link
Contributor

@Starkium Starkium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good to me, the tests are running, but we do need this moved to the redot-merge branch instead of main

@Tekisasu-JohnK Tekisasu-JohnK changed the base branch from master to redot-merge-code October 8, 2024 06:42
@Tekisasu-JohnK Tekisasu-JohnK deleted the Misc-branding-for-new-project-name branch October 9, 2024 21:43
@Spartan322 Spartan322 added bug rebranding issues and pr's related to engine rebranding topic:buildsystem topic:editor labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rebranding issues and pr's related to engine rebranding topic:buildsystem topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants