Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'Godot' with 'Redot' in Documentation #708

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Replace 'Godot' with 'Redot' in Documentation #708

merged 1 commit into from
Oct 15, 2024

Conversation

Majoramari
Copy link
Contributor

@Majoramari Majoramari commented Oct 14, 2024 •
edited by Spartan322
Loading

Fixes #706
This PR solve some issues with Redot docs like #706
image

And more

@Majoramari Majoramari mentioned this pull request Oct 14, 2024
Open
1 task
Spartan322
Spartan322 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@Spartan322 Spartan322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you also throw a once-over for the 4.3 branch too if you would.

@Spartan322 Spartan322 added the rebranding issues and pr's related to engine rebranding label Oct 14, 2024
SkogiB
SkogiB approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@SkogiB SkogiB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, looking forward the 4.3 one as well, Thanks man

@Majoramari Majoramari mentioned this pull request Oct 14, 2024
Merged
@Majoramari
Copy link
Contributor Author

Majoramari commented Oct 14, 2024 •
edited
Loading

Please wait I'll change references in this PR and #713

Done

decryptedchaos
decryptedchaos reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@decryptedchaos decryptedchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed ref to [RDShaderFile]

  • doc/translations/zh_CN.po
  • doc/classes/ResourceImporterShaderFile.xml

decryptedchaos
decryptedchaos approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@decryptedchaos decryptedchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good to go, we'll fix the RDShaderFile ref in another PR after we fix the class name.

@Spartan322
Copy link
Member

Could this please be squashed first.

@Majoramari Majoramari changed the title Changed "Godot" to "Redot" while preserving necessary references to previous versions of Godot. Replace 'Godot' with 'Redot' in Documentation (4.4 beta) Oct 15, 2024
@Majoramari
fix: replace "Godot" to "Redot"
f90d134 
Trying to change "Godot" to "Redot" in the doc while acknowledging the reference to previous Godot versions like Godot 3.X.
@Majoramari
Copy link
Contributor Author

Could this please be squashed first.

Squashed

@Spartan322 Spartan322 changed the title Replace 'Godot' with 'Redot' in Documentation (4.4 beta) Replace 'Godot' with 'Redot' in Documentation Oct 15, 2024
@Spartan322
Copy link
Member

Thank you.

@Spartan322 Spartan322 merged commit 26153b5 into Redot-Engine:master Oct 15, 2024
22 checks passed
@Majoramari Majoramari deleted the docs-redot-rename branch October 15, 2024 02:57
@Spartan322 Spartan322 added cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release and removed cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkogiB SkogiB SkogiB approved these changes

@Spartan322 Spartan322 Spartan322 approved these changes

@decryptedchaos decryptedchaos decryptedchaos approved these changes

Assignees
No one assigned
Labels
bug documentation rebranding issues and pr's related to engine rebranding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4.3] application/boot_splash/image documentation still refers to Godot
4 participants
@Majoramari @Spartan322 @decryptedchaos @SkogiB