Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo App] Update Label upon successful scan #102

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

LanceMcCarthy
Copy link
Contributor

The demo give the impression to some developers that a scan was not successful because the "Top Text..." label content doesn't update.

So I just added an x:Name to the label and update the value after a scan.

@LanceMcCarthy
Copy link
Contributor Author

Looking at the failed build output, I have a couple quick tips:

Error

The error is "Unspecified error", so I'm not much help there without digging deeper.

Issue

I can help with this one as I've had to update all my different libraries to use the new output variables approach.

Warning: The set-output command is deprecated and will be disabled soon

OLD:

$buildDay = Get-Date -Format "yyyy.Mdd"
$runNumber = "$env:GITHUB_RUN_NUMBER"
$ver = $buildDay + "." + $runNumber + ".0"

# deprecated way
echo "::set-output name=APP_VERSION::$ver"

NEW:

$buildDay = Get-Date -Format "yyyy.Mdd"
$runNumber = "$env:GITHUB_RUN_NUMBER"
$ver = $buildDay + "." + $runNumber + ".0"

#new way
echo "APP_VERSION=$ver" >> $GITHUB_OUTPUT

@Redth Redth merged commit d32ca7a into Redth:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants