Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow User Configuration of RPATH Settings #1002

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

ahnaf-tahmid-chowdhury
Copy link
Contributor

Description

This pull request introduces user-configurable options for controlling RPATH settings in the CMake build system. Previously, these settings were forced in the CMakeLists.txt file, leading to inflexibility and potential conflicts, as reported in issue #1001. By making these options configurable, users have more control over the behavior of RPATH settings during the build process.

Changes Made

  • Introduce options for enabling macOS RPATH, skipping build-time RPATH, and building with install RPATH.
  • Modify the logic to use user-configured options and provide feedback messages regarding the state of each option.
  • Refactor the setting of install RPATH to be conditional upon whether the directory is considered a system directory.

Checklist

  • The documentation has been updated.
  • If the PR solves a specific issue, it is set to be closed on merge.

Additional Notes

  • Please review and provide feedback.
  • This PR aims to address the reported issue and enhance the flexibility of RPATH settings in the CMake build system.

@langou
Copy link
Contributor

langou commented May 23, 2024

Thanks @ahnaf-tahmid-chowdhury.

This PR is ready for a merge. I will let it sit for a few days. If no one objects by then, I will merge.

@langou langou merged commit a4d0691 into Reference-LAPACK:master Jun 3, 2024
10 checks passed
@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury deleted the rpath-fix branch June 3, 2024 04:03
@haampie haampie mentioned this pull request Aug 7, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants