Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try flag -fcheck=all #515

Conversation

weslleyspereira
Copy link
Collaborator

@weslleyspereira weslleyspereira commented Mar 16, 2021

Fix #512 using @jabl (#339) and @mgates (#512 (comment)) suggestions.

Uses a flag LAPACK_FORTRAN_STRLEN_END in CBLAS and LAPACKE.

Maybe I shall also:

  • update make.inc.* with the new flag (I just used LAPACK_FORTRAN_STRLEN_END as set by default)
    ?? - [ ] change all methods in LAPACKE/include/lapack.h

@jabl
Copy link

jabl commented Mar 17, 2021

Note that at least for GFortran (since version 8), Intel Fortran, and I believe the new LLVM Fortran compiler (flang, previously f18) use size_t for the hidden character length argument, not unsigned int.

@weslleyspereira weslleyspereira force-pushed the try-flag--fcheck=bounds branch 2 times, most recently from 989c463 to e4440a7 Compare March 18, 2021 19:22
@weslleyspereira
Copy link
Collaborator Author

All builds shall pass with this last commit. I defined LAPACK_FORTRAN_STRLEN_END by default following @mgates3 comments in #512 and LAPACK++ convention.

Should we (maybe I) change all methods in LAPACKE/include/lapack.h to use the new flag LAPACK_FORTRAN_STRLEN_END ?
I think not for now, and maybe in a separate PR. My main objective here is to allow for the use of -fcheck=all.

@weslleyspereira weslleyspereira marked this pull request as ready for review March 18, 2021 19:24
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #515 (628a209) into master (55bdf7f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   83.33%   83.36%   +0.02%     
==========================================
  Files        1820     1820              
  Lines      170893   185545   +14652     
==========================================
+ Hits       142411   154673   +12262     
- Misses      28482    30872    +2390     
Impacted Files Coverage Δ
SRC/dbdsdc.f 68.82% <0.00%> (-7.18%) ⬇️
SRC/sbdsdc.f 68.82% <0.00%> (-7.18%) ⬇️
SRC/claunhr_col_getrfnp.f 39.28% <0.00%> (-6.55%) ⬇️
SRC/dlaorhr_col_getrfnp.f 39.28% <0.00%> (-6.55%) ⬇️
SRC/slaorhr_col_getrfnp.f 39.28% <0.00%> (-6.55%) ⬇️
SRC/zlaunhr_col_getrfnp.f 39.28% <0.00%> (-6.55%) ⬇️
SRC/ctgsen.f 67.79% <0.00%> (-6.03%) ⬇️
SRC/ztgsen.f 67.79% <0.00%> (-6.03%) ⬇️
SRC/zlarrv.f 57.44% <0.00%> (-5.94%) ⬇️
SRC/dtgsen.f 73.55% <0.00%> (-5.66%) ⬇️
... and 1264 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bdf7f...628a209. Read the comment docs.

@weslleyspereira weslleyspereira force-pushed the try-flag--fcheck=bounds branch from e4440a7 to da9e576 Compare March 18, 2021 21:17
…lt, following @mgates3 comments in @512 and LAPACK++ convention
@weslleyspereira weslleyspereira merged commit 3d67b01 into Reference-LAPACK:master Mar 25, 2021
@julielangou julielangou added this to the LAPACK 3.9.1 milestone Mar 25, 2021
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tests fail when compiled with -fcheck=bounds
4 participants