Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #685

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Fixes #685

merged 2 commits into from
Aug 3, 2022

Conversation

angsch
Copy link
Collaborator

@angsch angsch commented Jun 28, 2022

Description

  1. Fix an out-of-bounds write in the tests
  2. Fix documentation as reported in syswapr docs seem wrong #217. For the real routines, it would make sense to describe A as symmetric N-by-N matrix. For complex data types, the routine appears sensible for both symmetric and Hermitian matrices. For that reason, the commit intentionally does not state what (symmetric, Hermitian) A is. Additionally, replace the loops with calls to the BLAS to be consistent. Note that UPLO = 'Lower' already had a call to strided SWAP.

Checklist

  • The documentation has been updated.
  • If the PR solves a specific issue, it is set to be closed on merge.

langou
langou previously approved these changes Jun 30, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (a8b862c) compared to base (7d90a67).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head a8b862c differs from pull request most recent head c8a5cf5. Consider uploading reports for the commit c8a5cf5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1894     1894           
  Lines      184140   184070   -70     
=======================================
+ Misses     184140   184070   -70     
Impacted Files Coverage Δ
SRC/cgelss.f 0.00% <0.00%> (ø)
SRC/cheevd.f 0.00% <0.00%> (ø)
SRC/csyswapr.f 0.00% <0.00%> (ø)
SRC/cunbdb6.f 0.00% <0.00%> (ø)
SRC/dgelss.f 0.00% <0.00%> (ø)
SRC/dorbdb6.f 0.00% <0.00%> (ø)
SRC/dsyevd.f 0.00% <0.00%> (ø)
SRC/dsyswapr.f 0.00% <0.00%> (ø)
SRC/dsytrd_sy2sb.f 0.00% <0.00%> (ø)
SRC/sgelss.f 0.00% <0.00%> (ø)
... and 12 more

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

angsch added 2 commits August 3, 2022 09:02
The test driver allocates a scalar for INFO,
but the test writes to 3 entries. Revise
INFO allocation & propagation:

* Allocate sufficient space for the two INFOs
* Instead of discarding INFO computed in [ds]get40, return
  INFO to test driver
* Fix documentation of input/output arguments

[ds]get31: Fix typo in docs
@angsch angsch marked this pull request as ready for review August 3, 2022 18:07
@angsch
Copy link
Collaborator Author

angsch commented Aug 3, 2022

@langou Thanks for approving and sorry for the long delay with handling the CI failure.

@langou langou merged commit 3381a0e into Reference-LAPACK:master Aug 3, 2022
@angsch angsch deleted the fixes branch October 11, 2022 18:08
@julielangou julielangou added this to the LAPACK 3.11.0 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants