Set SCALE early for robust triangular solvers #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The changes look great to me, @angsch! However, I am not sure if we should remove LABAD from the complex routines or add it to the real-valued routines.
1) The docs define SCALE as an output argument. Set SCALE *before* the quick return case to have SCALE defined in all cases. This is how the similar routine TRSYL handles the case already. 2) Remove invocations of LABAD in complex routines and be consistent with their real counterparts, which do not call LABAD.
|
@weslleyspereira Thanks for your review. The remaining data types have been added; the link to the issue has been moved to the commit message. In view of #96, I did not reintroduce |
|
Thanks for citing issue #96 ! I talked to Jim Demmel and other people, and
they recommended removing those calls as well.
Weslley
…On Sun, Sep 25, 2022 at 10:22 AM angsch ***@***.***> wrote:
@weslleyspereira <https://github.com/weslleyspereira> Thanks for your
review. The remaining data types have been added; the link to the issue has
been moved to the commit message.
In view of #96 <#96>, I
did not reintroduce LABAD.
—
Reply to this email directly, view it on GitHub
<#712 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD6AT6OUKCKHOMIK22JCWHDWAB33LANCNFSM57FDVRMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Weslley S. Pereira
|
langou
approved these changes
Sep 29, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update robust triangular solver
LATRSand robust banded triangular solverLATBS.The docs define
SCALEas an output argument. SetSCALEbefore the quick return case to haveSCALEset (to the expected value 1.0) in all cases. This is how the similar routineTRSYLhandles the corner case already.Remove invocations of
LABADin complex routines and be consistent with the real counterparts, which do not callLABAD.