Added option to enable flat namespace on macOS #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #756. I've added an option to enable flat namespaces on macOS. If that option is ON we pass the
-flat_namespaceflag to the linker which fixes the symbol resolution of_xerblain the testing framework.Additionally, the issue with
cblas_xerbla(see #440) came up again on my local machine after some update. I'm actually not sure what I updated (I'm using GCC 12.2.0 and the newest command-line developer tools). I took a look at #521 which solved this issue before with weak symbols. The__attribute__((weak))was missing in the function declarations and the CBLAS tests were compiled without the-DHAS_ATTRIBUTE_WEAK_SUPPORTdefine. After I fixed those two things the tests worked again on my machine.I also fixed some formatting in cblas_f77.h.