Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C prototypes and LAPACKE interfaces for ?GEDMD/?GEDMDQ #880

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

martin-frbg
Copy link
Collaborator

Description
This part of PR #736 appears to have been based on an earlier implementation of the Dynamic Mode Decomposition functions than what actually got committed in the LAPACK source tree, leading to some argument type mismatches and missing parameters
fixes #879
Checklist

  • [N/A] The documentation has been updated.
  • If the PR solves a specific issue, it is set to be closed on merge.

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (308bf2f) 0.00% compared to head (c0a81c6) 0.00%.

❗ Current head c0a81c6 differs from pull request most recent head 914f719. Consider uploading reports for the commit 914f719 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1918     1918           
  Lines      188614   188614           
=======================================
  Misses     188614   188614           
Impacted Files Coverage Δ
SRC/csytrf.f 0.00% <0.00%> (ø)
SRC/csytrf_rk.f 0.00% <0.00%> (ø)
SRC/ctrevc3.f 0.00% <0.00%> (ø)
SRC/dsytrf.f 0.00% <0.00%> (ø)
SRC/dsytrf_rk.f 0.00% <0.00%> (ø)
SRC/dtrevc3.f 0.00% <0.00%> (ø)
SRC/ssytrf.f 0.00% <0.00%> (ø)
SRC/ssytrf_rk.f 0.00% <0.00%> (ø)
SRC/strevc3.f 0.00% <0.00%> (ø)
SRC/zsytrf.f 0.00% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

langou
langou previously approved these changes Jul 9, 2023
@martin-frbg martin-frbg marked this pull request as draft July 10, 2023 20:51
langou
langou previously approved these changes Jul 12, 2023
@martin-frbg martin-frbg marked this pull request as ready for review July 12, 2023 15:43
@weslleyspereira weslleyspereira merged commit 62e6bdf into Reference-LAPACK:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LAPACKE interfaces and C prototypes for ?GEDMD(Q) do not match the implementation
3 participants