allow absolute GNU install dirs #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1918 1918
Lines 188614 188614
=======================================
Misses 188614 188614 ☔ View full report in Codecov by Sentry. |
|
Hello @chayleaf. Would you be able to merge to/rebase with the current master branch? The script for the Github Actions needed to be updated in a recent commit. Thanks! |
CMAKE_INSTALL_LIBDIR is allowed to be an absolute path. Use CMAKE_INSTALL_FULL_LIBDIR instead.
chayleaf
force-pushed
the
gnu-install-dirs
branch
from
d5ba059
to
ddca837
Compare
weslleyspereira
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMAKE_INSTALL_LIBDIRis allowed to be an absolute path as per CMake docs. This patch changes the build script to useCMAKE_INSTALL_FULL_LIBDIRinstead, and gets rid of the prefix detection code (many other libraries, such as LLVM, have gotten rid of it already as it's quite finicky in practice due to absolute dirs being allowed).Absolute
CMAKE_INSTALL_LIBDIRs are used at least on NixOS. This is because NixOS packages are allowed to have multiple outputs (e.g. put docs in one dir, headers and other files for development to another, the binaries to a third one), and NixOS isn't FHS-compliant (There's no/usr, each package output has its own directory instead).GNU Guix is a similar distro, but I'm not sure how CMake packages are built there. Either way, it's good to fully conform to the spec.
Checklist