Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for CMake >= 3.27 #910

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

scivision
Copy link
Contributor

@scivision scivision commented Sep 18, 2023

CMake >= 3.27 warns if cmake_minimum_required(VERSION ) is less than 3.5.

CMake for Lapack was already using CMake 3.6 features.

@scivision scivision changed the title CMake 3.27 warns for cmake_minimum_required < 3.5 Fix build for CMake >= 3.27 Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ae2f14f) 0.00% compared to head (bd4bfaf) 0.00%.

❗ Current head bd4bfaf differs from pull request most recent head 0a52d71. Consider uploading reports for the commit 0a52d71 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1918     1918           
  Lines      188614   188614           
=======================================
  Misses     188614   188614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@weslleyspereira weslleyspereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change. The CMake build system in LAPACK may actually be using functionality from more recent versions of CMake anyway.

@ACSimon33
Copy link
Contributor

@weslleyspereira We need at least CMake 3.6 since we are using list(FILTER ..):

https://cmake.org/cmake/help/latest/command/list.html#filter

So maybe it makes sense to set the minimum version to 3.6

CMake 3.27 warns for cmake_minimum_required < 3.5
@weslleyspereira weslleyspereira merged commit 4174d8d into Reference-LAPACK:master Oct 12, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants